Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change structure of output and log directories #75

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Change structure of output and log directories #75

merged 7 commits into from
Mar 13, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Mar 7, 2024

Description

  • To make the path of the output files clear, its structure is modified.
  • Log files are moved into the COM directory.
  • This change partially follows the NCO implementation standards (path under COMROOT).

Anticipated changes to regression tests:

  • Is baseline change expected ?

Subcomponents involved:

  • DA_update (ufs-community/land-DA)
  • ufsLand.fd (NOAA-EPIC/ufs-land-driver-emc-dev)
  • ufs_model.fd (ufs-community/ufs-weather-model)
  • vector2tile_converter.fd (NOAA-PSL/land-vector2tile)
  • none

Linked PR's and Issues:

Testing (for CM's):

  • RDHPCS
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • CI
    • Completed
  • PW-Clouds
    • AWS
    • AZURE
    • GCP

@chan-hoo chan-hoo requested a review from jkbk2004 March 7, 2024 19:57
@chan-hoo
Copy link
Collaborator Author

chan-hoo commented Mar 7, 2024 

Orion-login-4[11] chjeon$ ctest
Test project /work/noaa/epic/chjeon/landda_test/land-DA_workflow/sorc/build
    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed    7.99 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed    8.77 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed   61.51 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    4.86 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed   14.08 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed   10.95 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed  586.78 sec

100% tests passed, 0 tests failed out of 7

Total Test time (real) = 695.06 sec

@chan-hoo chan-hoo linked an issue Mar 7, 2024 that may be closed by this pull request
Need to make structure of output directory clear #74
Closed
@zach1221 zach1221 added LandDA_workflow Label used to trigger a PR testing and removed LandDA_workflow Label used to trigger a PR testing labels Mar 11, 2024
@zach1221
Copy link
Collaborator

@chan-hoo don't we need to remove line 347 of app_build.sh or replace with "module purge'? I thought this was necessary to build successfully?

@chan-hoo
Copy link
Collaborator Author

@zach1221, removed.

Orion-login-4[4] chjeon$ ctest
Test project /work/noaa/epic/chjeon/landda_test/land-DA_workflow/sorc/build
    Start 1: test_vector2tile
1/7 Test #1: test_vector2tile .................   Passed    8.55 sec
    Start 2: test_create_ens
2/7 Test #2: test_create_ens ..................   Passed   13.62 sec
    Start 3: test_letkfoi_snowda
3/7 Test #3: test_letkfoi_snowda ..............   Passed   73.37 sec
    Start 4: test_apply_jediincr
4/7 Test #4: test_apply_jediincr ..............   Passed    5.00 sec
    Start 5: test_tile2vector
5/7 Test #5: test_tile2vector .................   Passed   12.93 sec
    Start 6: test_land_driver
6/7 Test #6: test_land_driver .................   Passed    8.49 sec
    Start 7: test_ufs_datm_land
7/7 Test #7: test_ufs_datm_land ...............   Passed  590.54 sec

100% tests passed, 0 tests failed out of 7

@kbooker79 kbooker79 added LandDA_workflow Label used to trigger a PR testing and removed LandDA_workflow Label used to trigger a PR testing labels Mar 12, 2024
@zach1221 zach1221 removed the LandDA_workflow Label used to trigger a PR testing label Mar 12, 2024
@zach1221 zach1221 added LandDA_workflow Label used to trigger a PR testing and removed LandDA_workflow Label used to trigger a PR testing labels Mar 12, 2024
@jkbk2004
Copy link
Collaborator

@chan-hoo I can approve if you are ok with my last two commits. There is jenkins pipeline ctest failure (test 6), which is nothing to do with this pr. we can capture after merging this pr. let me know.

@chan-hoo
Copy link
Collaborator Author

@jkbk2004, they look good. please approve this pr.

@chan-hoo chan-hoo merged commit 241a71e into ufs-community:develop Mar 13, 2024
4 of 8 checks passed
@chan-hoo chan-hoo deleted the feature/output branch March 20, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbk2004 jkbk2004 jkbk2004 approved these changes

Assignees
No one assigned
Labels
LandDA_workflow Label used to trigger a PR testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to make structure of output directory clear
4 participants
@chan-hoo @zach1221 @jkbk2004 @kbooker79